Closed guillesd closed 1 year ago
@jeremyyeo tagging you for visibility! @pgoslatara
@jeremyyeo does this need something to be merged?
@jeremyyeo Fixed the wrong reference to the docs. Anything else?
Hello, I am waiting for this PR to be merged, but is there any problem?
@jeremyyeo @jtcohen6 Hello, when will this PR Merged? I'm waiting for this feature
Thanks @guillesd - appreciate the contribution and apologies for taking forever to merge this :P
Description & motivation
Addresses https://github.com/dbt-labs/dbt-external-tables/issues/100 for the following adapters:
Checklist
Details
The
create_external_schema
macro is created, which takes in asource_node
and creates the schema. The macro is added to thebuild_plan
so that the process is more explicit (and logged). This macro is common for Snowflake, Spark and BigQuery and is overwritten in the SQL Server adapter. I did not use thecreate_schema
default macro of dbt since it takes in a different argument than asource_node
and I did not want to overwrite such a core macro for this.Hope you liked my approach!