dbt-labs / dbt-external-tables

dbt macros to stage external sources
https://hub.getdbt.com/dbt-labs/dbt_external_tables/latest/
Apache License 2.0
294 stars 119 forks source link

Fix databricks tests #183

Closed jeremyyeo closed 1 year ago

jeremyyeo commented 1 year ago

Description & motivation

Fix #181 Remove pinning pyodbc when installing dbt-spark at the same time (doesn't appear to be required anymore).

Checklist

jeremyyeo commented 1 year ago

@dbeatty10 can you check the profile-databricks context?

Something must be borked there. I added a new context profile-databricks-jeryeo with my own locally tested hostname, endpoint, and token and it worked as expected https://app.circleci.com/pipelines/github/dbt-labs/dbt-external-tables/280/workflows/449f8e2a-7375-4078-b63c-39e7e61c2330/jobs/1253

Something must be wrong there wrt hostname or endpoint or token or something with the profile-databricks context https://app.circleci.com/pipelines/github/dbt-labs/dbt-external-tables/279/workflows/3836ebcb-2c64-4bfb-a384-63cc580df8ce/jobs/1250

jeremyyeo commented 1 year ago

Notably for the previous issues with this test - dbt-spark[ODBC]==1.4.0-b1 was throwing exceptions:

image

Which of course doesn't seem to be the same error as mentioned in #180 😁

Which was fixed with dbt-spark[ODBC]==1.4.0-rc1:

image