Snowflake: Add expression parameter to columns

dbt-labs / dbt-external-tables

dbt macros to stage external sources

https://hub.getdbt.com/dbt-labs/dbt_external_tables/latest/

Apache License 2.0

288 stars 116 forks source link

Snowflake: Add expression parameter to columns #209

Closed ipear3 closed 3 months ago

ipear3 commented 1 year ago

Description & motivation

resolves: #140

Implements #140 - extending the snowflake plugin to allow custom expression for virtual columns
Adds support for column identifiers in Snowflake external tables. Allowing identifier in addition to name enables aliasing virtual columns within the external table model rather than a subsequent model.

Checklist

[x] I have verified that these changes work locally
[x] I have updated the README.md (if applicable) <- Not applicable, but updated sample_sources/snowflake.yml
[x] I have added an integration test for my fix/feature (if applicable)

moseleyi commented 1 year ago

This would be such a great addition!

dweaver33 commented 1 year ago

We are eagerly awaiting this PR. This will fix the issue when a source field is named value and you are unable to create the field in Snowflake.

dweaver33 commented 1 year ago

@jeremyyeo, any update on this?

jeremyyeo commented 1 year ago

Hey folks - we'll try to get this merged this week.

devdazed commented 11 months ago

Any update on this? we would really love to have this feature included in the package

github-actions[bot] commented 5 months ago

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

devdazed commented 5 months ago

yes, what is the hesitation to merging this?

ShahNewazKhan commented 5 months ago

are there plans to add tests for this pr?

kyleburke-meq commented 3 months ago

@jeremyyeo is there any update on merging this?

dataders commented 3 months ago

@ipear3 (and everyone following along). I would like to merge this PR, but it has conflicts with the already merged #211.

I'd welcome anyone to open a new PR based on the commits here that resolve the conflict in a meaningful way

kyleburke-meq commented 3 months ago

@dataders I have resolved the merge conflict here: https://github.com/dbt-labs/dbt-external-tables/pull/275

dataders commented 3 months ago

closing in favor of #275