Snowflake: Add expression parameter to columns

dbt-labs / dbt-external-tables

dbt macros to stage external sources

Apache License 2.0

313 stars 123 forks source link

Closed kyleburke-meq closed 7 months ago

kyleburke-meq commented 7 months ago

resolves: #140

Adds the ability for custom expressions and identifiers to external sources in snowflake.

All credit goes to @ipear3 and his original PR: https://github.com/dbt-labs/dbt-external-tables/pull/209 I am just resolving a merge conflict and want to see the code implemented.

cakkinep commented 7 months ago

depending on the order of the merges, we will have to resolve conflicts with #257 , i am adding column alias functionality there.

kyleburke-meq commented 7 months ago

@dataders is there something preventing this PR from being merged?

the-davidsn commented 7 months ago

+1 This feature is pretty helpful - especially when trying to handle timestamps w/ parquet files :)

kyleburke-meq commented 7 months ago

@dataders I have updated the integration test so it is now passing. I also resolved the conflict with https://github.com/dbt-labs/dbt-external-tables/pull/257.

Would you kindly review this again?

cakkinep commented 7 months ago

@kyleburke-meq thanks for resolving the conflicts and adding the integration test for the changes.