dbt-labs / dbt-external-tables

dbt macros to stage external sources
https://hub.getdbt.com/dbt-labs/dbt_external_tables/latest/
Apache License 2.0
298 stars 120 forks source link

fix integration_test from #257 #286

Closed cakkinep closed 5 months ago

cakkinep commented 5 months ago

Description & motivation

resolves: #285 This PR is to fix integration test error from #257

Checklist

dataders commented 5 months ago

thanks for jumping in to help with this so quickly @cakkinep! I actually started on a similar implementation before I even saw this PR.

I went with my version in #290 because it actually tests that the alias works post-hoc not just that the DDL statement does not error out (also maybe I'm biased :) )

One challenge was that I had to force merge my PR because of the way the integration tests are configured, i.e. tests are always run against the version of integration_tests.yml in the main branch.

however, I'm stumped as to why the tests in this PR were still failing... might need to look more into that if we see this come up again