dbt-labs / dbt-jsonschema

Apache License 2.0
109 stars 40 forks source link

recommended config links to outdated schema files #133

Open gofford opened 2 months ago

gofford commented 2 months ago

Using the jsonschema config from the README I noticed that some valid yaml config was being flagged as an error. Looking into it it seems that the config in the README is linking to outdated schema files.

The stated config is equivalent to sourcing https://github.com/dbt-labs/dbt-jsonschema/blob/main/schemas/dbt_project.json which hasn't been updated in 4 months. In contrast the versioned schema files (https://github.com/dbt-labs/dbt-jsonschema/tree/main/schemas/latest) were updated 4 days ago -- these changes aren't being reflected, hence my error.

If I update the yaml.schemas config to use the latest files my "error" goes away.

Two ways of solving this:

I'm happy to PR this - which one do you prefer?

dave-connors-3 commented 2 months ago

@gofford i think the first option sounds right to me! the schemas currently in noted in the README are mostly there for backwards compatibility, and won't get updates, so we should point folks to the latest ones. Thanks for the callout!