Closed Cabeda closed 3 years ago
For info with the additional protocol.v1.alternate-header-name=Presto property in Trino conf, dbt-presto plugin works well with last Trino version trino-server-355
@victorcouste that's great! However, as stated on trino docs I think we should consider this as a temporary solution. Or do you think otherwise?
@Cabeda yes I think it should be a temporary solution, waiting dbt to accept "trino" as the header name
I'm going to try locally to perform the string replacement (presto -> trino) and use the trino python client and see if creating this new adapter works without too much effort. In case if it does and it gets polished enough, can this be taken under the fishanalytics umbrella?
I have a first draft here: https://github.com/findinpath/dbt-trino
While trying to run
docker run --network=dbt-net -v /home/findinpath/dbt-trino/docker/dbt:/root/.dbt dbt-trino init test
(as part of ./docker/run_tests.bash
script) I get the exception:
Running with dbt=0.20.0-rc2
Creating dbt configuration folder at /home/dbt_user/.dbt
With sample profiles.yml for redshift
Encountered an error:
Got a non-zero returncode running: ['/usr/bin/git', 'clone', '--depth', '1', '--branch', 'dbt-yml-config-version-2', 'https://github.com/fishtown-analytics/dbt-starter-project.git', 'test']
I assume that this is a consequence of the fishtown-analytics
to dbt-labs
right?
I have released in the meantime dbt-trino package to pypi .
See https://github.com/findinpath/dbt-trino
I think that this issue can be closed now
With the rename of prestosql to Trino I think this adapter will stop to work for the ones not using PrestoDB (developed by facebook).
Should a new one be created for the ones using Trino?