dbt-labs / dbt-project-evaluator

This package contains macros and models to find DAG issues automatically
https://dbt-labs.github.io/dbt-project-evaluator/latest/
Apache License 2.0
440 stars 64 forks source link

rejoining_of_upstream_concepts test doesn't ignore exposures and metrics correctly #433

Closed AlexPuletti closed 6 months ago

AlexPuletti commented 7 months ago

Describe the bug

It appears fct_rejoining_of_upstream_concepts is trying to filter out exposures and metrics here but it's filtering using ('exposures', 'metrics') when it looks like parent_resource_type and child_resource_type are actually exposure and metric (non-plural). Because of this, the filter isn't working properly.

Steps to reproduce

We have an exposure in our dbt project and it's failing the rejoining_of_upstream_concepts check and I can see the resource_type is listed as 'exposure' not 'exposures'

Screen Shot 2024-02-27 at 9 41 14 PM

Expected results

Exposures and Metrics successfully ignored by the rejoining_of_upstream_concepts test.

Actual results

Exposures and Metrics are not successfully ignored by the rejoining_of_upstream_concepts test.

Screenshots and log output

System information

The contents of your packages.yml file: packages:

Which database are you using dbt with?

The output of dbt --version:

1.6

Additional context

Are you interested in contributing the fix?

Sure

dave-connors-3 commented 6 months ago

hey @AlexPuletti! would welcome a PR if you're still interested!

AlexPuletti commented 6 months ago

hey @AlexPuletti! would welcome a PR if you're still interested!

happy to!