Rename tests: to data_tests: - Githubissues

dbt-labs / dbt-project-evaluator

This package contains macros and models to find DAG issues automatically

https://dbt-labs.github.io/dbt-project-evaluator/latest/

Apache License 2.0

453 stars 69 forks source link

Rename tests: to data_tests: #471

Closed tuebolo closed 1 month ago

tuebolo commented 4 months ago

This is a:

[x] bug fix PR with no breaking changes
[ ] new functionality

Link to Issue

Description & motivation

changes from tests to data_tests due the 1.8 deprecation

Integration Test Screenshot

Checklist

[ ] I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
- [ ] BigQuery
- [ ] Postgres
- [ ] Redshift
- [ ] Snowflake
- [ ] Databricks
- [ ] DuckDB
- [ ] Trino/Starburst
[ ] I have updated the README.md (if applicable)
[ ] I have added tests & descriptions to my models (and macros if applicable)

b-per commented 4 months ago

Thanks for this.

We should definitely update the convention when we make the package valid for 1.8+ only (and do a new release with this restriction).

But I think that there was a recent issue fixed in dbt-core to stop warnings for tests => data_tests for packages. So, those warnings should soon disappear even without this PR.