search

dbt-labs / dbt-project-evaluator

This package contains macros and models to find DAG issues automatically
https://dbt-labs.github.io/dbt-project-evaluator/latest/
Apache License 2.0
447 stars 67 forks source link

Incorporate operating system detection into path exclusions #485

Closed katieclaiborne-duet closed 2 months ago

katieclaiborne-duet commented 2 months ago

Describe the feature

I'd like to define a path to be excluded in the exclude_paths_from_project variable, and have it correctly excluded for both Windows and Mac users.

Describe alternatives you've considered

We currently have duplicate entries in the exclude_paths_from_project variable: one for each operating system.

exclude_paths_from_project: ['models/utilities/', 'models\\\\utilities\\\\']

Additional context

Who will this benefit?

This feature will be useful for teams with developers on different operating systems.

These could be teams at young companies, and/or teams that contract with part-time developers.

Are you interested in contributing this feature?

Yes, although I'd likely need a hand!

b-per commented 2 months ago

If you would like to contribute I think that we could update the code here

https://github.com/dbt-labs/dbt-project-evaluator/blob/fb96c460a870ae50df3ebdc5080d12d0a27be7a9/macros/set_is_excluded.sql#L22

and create a new variable that would duplicate the entries to the Windows version automatically. We would then loop through that new variable.