dbt-labs / dbt-project-evaluator

This package contains macros and models to find DAG issues automatically
https://dbt-labs.github.io/dbt-project-evaluator/latest/
Apache License 2.0
447 stars 67 forks source link

Add Windows version of each exclusion item to duplicated list #486

Closed katieclaiborne-duet closed 2 months ago

katieclaiborne-duet commented 2 months ago

This is a:

Link to Issue

Closes #485

Description & motivation

Based on Benoit's suggestion, I've:

These changes will allow teams to define a single set of paths to exclude, rather than having to define each path and its Windows equivalent.

Integration Test Screenshot

image

Checklist

Testing

I don't have a Windows machine, but worked with a teammate who does to test these changes.

In our private dbt repo, we:

image
b-per commented 2 months ago

As this is a tiny improvement with no new dbt rule/test and no impact to current users I am going to do a patch release instead of a minor one.

katieclaiborne-duet commented 2 months ago

It's good that you managed to test on Windows with a colleague, because otherwise I am not sure we would have figured out how many \ were required 😄

Haha, yes! I was grateful for a copilot.