dbt-labs / dbt-project-evaluator

This package contains macros and models to find DAG issues automatically
https://dbt-labs.github.io/dbt-project-evaluator/latest/
Apache License 2.0
447 stars 67 forks source link

Missing handling of exceptions for Duplicate Sources #498

Closed d-roman-halliday closed 1 month ago

d-roman-halliday commented 1 month ago

Describe the bug

When trying to add exceptions to dbt_project_evaluator_exceptions.csv for fct_duplicate_sources, they aren't being applied to the model as generated by dbt.

It looks like the code for fct_duplicate_sources doesn't contain the function to dynamically generate exceptions {{ filter_exceptions() }} in the same way fct_direct_join_to_source does:

Steps to reproduce

Expected results

Exceptions are added to generated code, similar to other tests.

Actual results

Tests continue to fail, despite exceptions being configured.

Screenshots and log output

System information

The contents of your packages.yml file:

packages:
  - package: dbt-labs/dbt_project_evaluator 
    version: [">=0.14.0", "<0.15.0"] 

Which database are you using dbt with?

The output of dbt --version:

Core:
  - installed: 1.6.0
  - latest:    1.8.6 - Update available!

  Your version of dbt-core is out of date!
  You can find instructions for upgrading here:
  https://docs.getdbt.com/docs/installation

Plugins:
  - snowflake:  1.6.0 - Update available!

Additional context

n/a

Are you interested in contributing the fix?

I think it's a simple case of adding the one line to fct_duplicate_sources. Aware it may be omitted for architectural or other reasons.