dbt-labs / dbt-redshift

dbt-redshift contains all of the code enabling dbt to work with Amazon Redshift
https://getdbt.com
Apache License 2.0
95 stars 58 forks source link

[Feature] Remove `dbt-postgres` dependency #811

Open mikealfare opened 4 months ago

mikealfare commented 4 months ago

Describe the feature

dbt-redshift depends on dbt-postgres for 8 macros. These are all "pass-through" macros, e.g.:

{% macro redshift__create_schema(relation) -%}
  {{ postgres__create_schema(relation) }}
{% endmacro %}

We can eliminate the dependency on dbt-postgres through a combination of vendoring the dbt-postgres macros into dbt-redshift and simply relying on the default in dbt-adapters.

Tasks

colin-rogers-dbt commented 4 months ago

Need to communicate that this would break any redshift user who is depending on overwriting a postgres macro.

padbk commented 4 months ago

This change would be much appreciated.

dbt-postgres 1.8.0 is creating issues for those running Linux due to a change in Psycopg2 dependencies, see https://github.com/dbt-labs/dbt-postgres/issues/96

dbt-redshift does not need Psycopg2 anymore, so removing this dependency is a much needed simplfication. 🙏

jtcohen6 commented 3 months ago

We've identified a blocker for this work: