search

dbt-labs / dbt-rpc

A server that can compile and run queries in the context of a dbt project. Additionally, it provides methods that can be used to list and terminate running processes.
https://docs.getdbt.com/reference/commands/rpc
Apache License 2.0
19 stars 7 forks source link

[CT-1689] Check exceptions #111

Closed emmyoop closed 1 year ago

emmyoop commented 1 year ago

dbt-core has deprecated functions to raise exceptions in favor of directly raising the exceptions. Nothing should be broken (yet) and the functions still raise as expected but they also will log a deprecation warning (pending https://github.com/dbt-labs/dbt-core/pull/6413). It would be good to resolve these deprecation messages before the 1.4 rc.

There are a lot of deprecated function so it's easier to search for dbt.exceptions and look at each callsite to determine if it's using a function or already directly raising an exception. Then replace anywhere using functions with directly raising an exception.

We can create new exceptions in dbt-core to raise or the adapters could start to own their own exceptions within the adapter code base that inherit from exceptions in dbt-core.

For examples, see https://github.com/dbt-labs/dbt-core/pull/6347 that replaced all functions with raises.

github-actions[bot] commented 1 year ago

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.