search

dbt-labs / dbt-rpc

A server that can compile and run queries in the context of a dbt project. Additionally, it provides methods that can be used to list and terminate running processes.
https://docs.getdbt.com/reference/commands/rpc
Apache License 2.0
19 stars 7 forks source link

[CT-1730] RPC Failure after recent update to source JSON-RPC JSONRPCResponseManager class #116

Closed anubhavsharma515 closed 1 year ago

anubhavsharma515 commented 1 year ago

Good day and Merry Christmas!

On merging in https://github.com/pavlov99/json-rpc/pull/122, it seems like there was a modification to the JSONRPCResponseManager class which the dbt_rpc/response_manager inherits from:

https://github.com/dbt-labs/dbt-rpc/blob/43a13999441268d220236bc230791554daa78320/dbt_rpc/rpc/response_manager.py#L69-L88

As a result an error of the form _get_responses() takes 3 positional arguments but 4 were given is being thrown.

I'm not sure how to help resolve this, but I believe it should be a fairly straightforward fix? Would really appreciate help with this as our project's orchestration relies on the dbt-core and the rpc server.

dima898 commented 1 year ago

Hi! Would also appreciate the fix for this issue. @anubhavsharma515 For now as a workaround, downgrading json-rpc package to version 1.12.1 worked for me.

anubhavsharma515 commented 1 year ago

Hey @dima898, thanks so much for the advice - thats exactly what I did after a few days of failures 🙂 . Just for your context, I have a PR up #118 that I believe fixes this issue.