[CT-1863] Support dbt-core 1.5 in `dbt-rpc`

dbt-labs / dbt-rpc

A server that can compile and run queries in the context of a dbt project. Additionally, it provides methods that can be used to list and terminate running processes.

https://docs.getdbt.com/reference/commands/rpc

Apache License 2.0

19 stars 7 forks source link

[CT-1863] Support dbt-core 1.5 in `dbt-rpc` #122

Closed ChenyuLInx closed 1 year ago

ChenyuLInx commented 1 year ago

As the exploration we did with #113, it is possible to continue supporting dbt-core for one more version with dbt-rpc. As the API-ification project moving on, there are likely new things that we need to adjust to make dbt-rpc working(i.e. manifest got refactored). This work should be estimated and being worked on after we merge feature/click-cli in dbt-core to main.

We should make sure all integration tests in dbt-rpc pass with latest main branch of dbt-core

iknox-fa commented 1 year ago

LG 1/30/2023 @ChenyuLInx and @stu-k are going to pair and better refine this ticket for grooming next time.

stu-k commented 1 year ago

I pushed the changes I think fix the change to manifest generation abstraction to this branch. Any work around this should probably be relegated to testing!

iknox-fa commented 1 year ago

After more code diving we discovered that we override init so the change in function sig isn't an issue.