Save args in config when cli_vars is saved

gshank commented 2 years ago

This is for bug #4583 in dbt-core, var not injected in dbt run snapshot from dbt run invocation in 1.0.0.

jtcohen6 commented 2 years ago

Looks good in local testing! I shared a Loom with my experience getting everything set up + verified.

Let me know if you need help with automated/integration testing. The RPC tests work a bit differently (and honestly better) vs. our current dbt-core integration testing.

After merging, let's plan to:

Test using the development (HEAD) branch of dbt Cloud (includes all changes from this repo's main branch)
Cut a prerelease, for use alongside dbt-core==1.0.2rc1
If everything looks good, cut a final release, coordinated with dbt-core==1.0.2 (final)

jtcohen6 commented 2 years ago

@gshank @leahwicz Do we have a clear path forward for this one? Should we proceed with the next steps I listed above?

dbt-labs / dbt-rpc

Save args in config when cli_vars is saved #70