dbt-labs / dbt-semantic-interfaces

The shared semantic layer definitions that dbt-core and MetricFlow use.
Apache License 2.0
68 stars 14 forks source link

[Feature] Add `call_parameter_sets` to the `WhereFilter` Protocol #109

Closed plypaul closed 1 year ago

plypaul commented 1 year ago

Is this your first time submitting a feature request?

Describe the feature

call_parameter_sets is currently a property on the Pydantic implementation of the WhereFilter. Since this property might be more broadly useful, it should be moved into the protocol definition.

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

Yes

Anything else?

No response

QMalcolm commented 1 year ago

To expand upon "more broadly used". What we're trying to solve with this is that the where_sql_template str is currently a highly structured string, but the string actually isn't guaranteed in the protocol in anyway. Although the protocol won't directly guarantee the the structure of the string, this allows us to write a validation that guarantees the the protocol. Moving the structure from not being controlled to being indirectly controlled.