Rename `SavedQuery.group_bys` to `SavedQuery.group_by`

[plypaul]

Resolves #192

Description

Please see associated issue for more details.

Checklist

• [x] I have read the contributing guide and understand what's expected of me
• [x] I have signed the CLA
• [x] This PR includes tests, or tests are not required/relevant for this PR
• [x] I have run changie new to create a changelog entry

[github-actions[bot]]

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

[plypaul]

@QMalcolm - How do we go about handling this kind of rename on the dbt-core side?

[QMalcolm]

@QMalcolm - How do we go about handling this kind of rename on the dbt-core side?

We can't, at least not for dbt-core 1.7, and that is a for a few reasons

• dbt-core 1.7 will depend on DSI 0.3.x, and we can't backport this to 0.3.latest because it's breaking
• dbt-core handles this via detecting manifest schema versions. Only 1 schema exists per dbt-core minor version
  • group_bys was introduced in 1.7.0rc1, thus there is no schema migration path for this property in core 1.7.latest

The only way to do this currently for dbt-core 1.7.0 and DSI 0.3.0 would be to support both, which also seems undesireable

[QMalcolm]

Also I have a few separate questions:

1. Is there context on why we want to rename this? The listed metricflow issue has group_bys not group_by
2. For this kind of work going forward can we get a DSI issue created? I had no idea this was coming down the pipe and I'm missing a lot of context of what we actually want to get it into. Additionally with automatically creating release changelog via changie we need to link to issues in this project.

[QMalcolm]

We'll put this into 0.4.0 and then jam that into the final cut of dbt-core 1.7.0

[plypaul]

@QMalcolm - Good point, created an issue in DSI and updated links.