dbt-labs / dbt-semantic-interfaces

The shared semantic layer definitions that dbt-core and MetricFlow use.
Apache License 2.0
66 stars 13 forks source link

[Feature] Add validations for conversion metrics #211

Closed WilliamDee closed 9 months ago

WilliamDee commented 10 months ago

Is this your first time submitting a feature request?

Describe the feature

As conversion metrics rolls out, we need validations on the parser to ensure the correct configs are passed.

Proposed Rules:

  1. entity must exist in both the semantic models that the base_measure and conversion_measure are in
  2. base_measure and conversion_measure must be valid and can only be SUM(1) or COUNT or DISTINCT_COUNT measures
  3. In constant_properties, both property that is stated must be referencing either an existing dimension/entity in the respective base/conversion semantic model

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response