dbt-labs / dbt-semantic-interfaces

The shared semantic layer definitions that dbt-core and MetricFlow use.
Apache License 2.0
66 stars 13 forks source link

[SL-1603] Remove `create_metric` from protocol spec #255

Closed QMalcolm closed 1 month ago

QMalcolm commented 7 months ago

Housekeeping

Short description

The measure property create_metric currently exists in protocol spec, the pydantic implementation, and even has a transformation rule CreateProxyMeasureRule which utilizes it. All of these are remnants of the pre MetricFlow x dbt core integration world. The truth is that create_metric is a parse time configuration and not a query time configuration. It shouldn't exist in the protocols because create_metric is not a semantic layer concern.

Acceptance criteria

Impact to Other Teams

This work impacts the Semantic Layer Team, Cloud Artifacts Team, and Core Team at dbt Labs.

Will backports be required?

No

Context

No response

SL-1603