Improve validations for derived metrics - Githubissues

dbt-labs / dbt-semantic-interfaces

The shared semantic layer definitions that dbt-core and MetricFlow use.

Apache License 2.0

66 stars 13 forks source link

Improve validations for derived metrics #279

Closed courtneyholcomb closed 3 months ago

courtneyholcomb commented 3 months ago

Resolves #270

Description

Improve validations for derived metrics.

If there were no input metrics set, previously users would run into an AssertionError that interrupts the semantic manifest validation process. This changes that to be a more user-friendly validation error.
Add a validation to ensure that expr is set and that it references all the input metrics.

Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have signed the CLA
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have run changie new to create a changelog entry