search

dbt-labs / dbt-semantic-interfaces

The shared semantic layer definitions that dbt-core and MetricFlow use.
Apache License 2.0
66 stars 13 forks source link

Don't require `time_granularity_name` in `QueryInterfaceTimeDimensionFactory` #307

Closed courtneyholcomb closed 2 months ago

courtneyholcomb commented 2 months ago

Resolves #306

Description

Currently, the protocol for QueryInterfaceTimeDimensionFactory requires time_granularity_name to be set. This is inconsistent with other interfaces, where granularity is not required and can be resolved at query time. For example, the DSI implementation of this protocol (WhereFilterTimeDimensionFactory) does not require the parameter, but the implementation in MFS does. I did not include tests since this is a change to the protocol only. The corresponding change in MFS will have tests.

Checklist