Add validation warning when filter is applied to conversion input measure

dbt-labs / dbt-semantic-interfaces

The shared semantic layer definitions that dbt-core and MetricFlow use.

Apache License 2.0

72 stars 14 forks source link

Add validation warning when filter is applied to conversion input measure #350

Closed WilliamDee closed 1 month ago

WilliamDee commented 1 month ago

Resolves SL-2862

Description

Since filtering on a conversion input measure is not fully supported, we will add a warning when this is added to let the user know.

Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have signed the CLA
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have run changie new to create a changelog entry

linear[bot] commented 1 month ago

SL-2862 Add validations when someone adds a filter on a conversion measure.

WilliamDee commented 1 month ago

Note that this will need a version bump (prod version) so we can release it and get it into core. And then a core PR that bumps to that version.

@courtneyholcomb Are there any other validation tasks? Would it make sense to wait for some of those to be done then we can batch all those up and release it once?

courtneyholcomb commented 1 month ago

Note that this will need a version bump (prod version) so we can release it and get it into core. And then a core PR that bumps to that version.

@courtneyholcomb Are there any other validation tasks? Would it make sense to wait for some of those to be done then we can batch all those up and release it once?

@WilliamDee Good call, yeah I think there are! Can you put up a task to make sure we don't forget?