Closed WilliamDee closed 6 days ago
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.
Description
Support custom grain by switching the typing to be not on
TimeGranularity
Metric.time_granularity
-TimeGranularity -> str
Metric.type_params.cumulative_type_params.grain_to_date
-TimeGranularity -> str
MetricInput.offset_to_grain
-TimeGranularity -> str
MetricTimeWindow.granularity
-TimeGranularity -> str
affects the followingMetric.type_params.conversion_type_params.window
Metric.type_params.cumulative_type_params.window
MetricInput.offset_window
Changes to
MetricTimeWindow
Because
MetricTimeWindow.granularity
is now a string, we allow it to be not as strict when ensuring it's a valid granularity during initial yaml parsing (since we don't have access to the custom granularities). Then during validations, we will properly validate that it's a valid grain, and during the transformation step we will remove trailing 's'.Checklist
changie new
to create a changelog entryResolves SL-2826