[Feature] Support Snowflake China host OAuth connection snowflakecomputing.cn

dbt-labs / dbt-snowflake

dbt-snowflake contains all of the code enabling dbt to work with Snowflake

https://getdbt.com

Apache License 2.0

280 stars 172 forks source link

[Feature] Support Snowflake China host OAuth connection snowflakecomputing.cn #1024

Open AndrewCanva opened 5 months ago

AndrewCanva commented 5 months ago

Is this your first time submitting a feature request?

[X] I have read the expectations for open source contributors
[X] I have searched the existing issues, and I could not find an existing issue for this feature
[X] I am requesting a straightforward extension of existing dbt-snowflake functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Snowflake has initiated the private preview of their product in China, with plans to transition into a public preview in June 2024. Presently, connections to Snowflake China are not possible through the standard snowflakecomputing.com host; instead, the regional host snowflakecomputing.cn must be used.

Describe alternatives you've considered

N/A

Who will this benefit?

dbt and snowflake users in China

Are you interested in contributing this feature?

yes

Anything else?

N/A

jtcohen6 commented 5 months ago

Hey @AndrewCanva, thanks for opening!

Do you happen to know more details (or could link us to documentation) about Snowflake China?

dbt-snowflake connects to Snowflake using snowflake-connector-python, by passing in the account identifier. However snowflake-python-connector wants to receive region/organization/account identifiers for Snowflake China, that's how we'll want to provide it as well.

AndrewCanva commented 4 months ago

Hey @AndrewCanva, thanks for opening!

Do you happen to know more details (or could link us to documentation) about Snowflake China?

dbt-snowflake connects to Snowflake using snowflake-connector-python, by passing in the account identifier. However snowflake-python-connector wants to receive region/organization/account identifiers for Snowflake China, that's how we'll want to provide it as well.

@jtcohen6 the error was gone after I added host parameter in the connection profile because I used snowflake/externalbrowser authenticator, but I guess it would cause errors if oAuth authenticator method is configured re https://github.com/dbt-labs/dbt-snowflake/blob/5459fbf0aa1bb40e800b89200442fcab47504157/dbt/adapters/snowflake/connections.py#L57

jtcohen6 commented 4 months ago

@AndrewCanva Makes sense. I'm going to keep this one on the backlog for now, and we can pick it up when someone needs it. Good to have it searchable in the meantime.