[Bug] missing @dataclass decorator from both `SnowflakeRelationType` `SnowflakeIncludePolicy

dataders commented 6 months ago

Is this a new bug in dbt-snowflake?

[X] I believe this is a new bug in dbt-snowflake
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

https://github.com/dbt-labs/dbt-snowflake/blob/3ac7f759012423506881ea80e14874c3b841884b/dbt/adapters/snowflake/relation_configs/policies.py#L7-L18

Expected Behavior

they should be dataclasses!

Steps To Reproduce

n/a

Relevant log output

No response

Environment

- OS:
- Python:
- dbt-core:
- dbt-snowflake:

Additional Context

No response

mikealfare commented 4 months ago

@dataders I know you found an issue that this caused but I can't remember what it was. If you remember, could you please add it?

dataders commented 4 months ago

The issue I came across was that I copied Snowflakes policies.py to use as a starting point to implement IncludePolicy for another adapter that actually required database to no be included.

Sometimes I see errors related to this, but it's never the culprit.

dbt-labs / dbt-snowflake