dbt-labs / dbt-snowflake

dbt-snowflake contains all of the code enabling dbt to work with Snowflake
https://getdbt.com
Apache License 2.0
297 stars 177 forks source link

quoting config not working with 1.8 #1075

Closed McKnight-42 closed 5 months ago

McKnight-42 commented 5 months ago

resolves #1074 docs dbt-labs/docs.getdbt.com/#

Problem

During decoupling work we updated some naming conventions in some macros that seem to go around quotiing_policy, reverting to put us back in good standing.

Solution

revert to using schema_relation where able in the adapters.sql if schema_relation is a string, otherwise use schema_relation.include(indentifier=False)

update tests in tests/functional/adapter/list_relations_tests/test_pagination.py to use a SnowflakeRelation object instead of a dict

add a new test based of the edgecase from issue.

Todo:

Checklist

mikealfare commented 5 months ago

We do this in two spots, so this line would also need updating.