dbt-labs / dbt-snowflake

dbt-snowflake contains all of the code enabling dbt to work with Snowflake
https://getdbt.com
Apache License 2.0
297 stars 177 forks source link

Add Python 3.12 to list of supported Python versions #1144

Closed VersusFacit closed 4 months ago

VersusFacit commented 4 months ago

resolves #903

Problem

Adding Python 3.12 should pass a series of tests

Solution

No code changes beyond GHA workflows and setup.py are needed for this adapter.

Checklist

github-actions[bot] commented 4 months ago

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

VersusFacit commented 4 months ago

Verified working release job for 3.12 enabled 🎉

https://github.com/dbt-labs/dbt-snowflake/actions/runs/10046736112/job/27766937211

You can also see 3.12 integration tests working on this very PR.

https://github.com/dbt-labs/dbt-snowflake/actions/runs/10046882814/job/27767327557?pr=1144

mikealfare commented 4 months ago

We also need to update these lines: https://github.com/dbt-labs/dbt-snowflake/blob/2cdcf2b7a4c8bba2ab9fcc6ca485dc381eadb05b/.github/scripts/integration-test-matrix.js#L3 https://github.com/dbt-labs/dbt-snowflake/blob/2cdcf2b7a4c8bba2ab9fcc6ca485dc381eadb05b/tox.ini#L3 https://github.com/dbt-labs/dbt-snowflake/blob/2cdcf2b7a4c8bba2ab9fcc6ca485dc381eadb05b/tox.ini#L5 https://github.com/dbt-labs/dbt-snowflake/blob/2cdcf2b7a4c8bba2ab9fcc6ca485dc381eadb05b/tox.ini#L16 https://github.com/dbt-labs/dbt-snowflake/blob/2cdcf2b7a4c8bba2ab9fcc6ca485dc381eadb05b/.pre-commit-config.yaml#L25-L31