Throw error when building Iceberg tables without behavior flag set - Githubissues

dbt-labs / dbt-snowflake

dbt-snowflake contains all of the code enabling dbt to work with Snowflake

https://getdbt.com

Apache License 2.0

297 stars 177 forks source link

Throw error when building Iceberg tables without behavior flag set #1184

Closed VersusFacit closed 2 months ago

VersusFacit commented 2 months ago

Problem

We need to log the behavior flag for iceberg not enabled but it's difficult to keep this from spiraling into hundreds or thousands of entries.

This PR presents a patch for now until base adapter is worked on.

Solution

Monkey patch Relation.

Checklist

[ ] I have read the contributing guide and understand what's expected of me
[ ] I have run this code in development and it appears to resolve the stated issue
[ ] This PR includes tests, or tests are not required/relevant for this PR
[ ] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

github-actions[bot] commented 2 months ago

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.