Adap 321/support all on schema change options - Githubissues

dbt-labs / dbt-snowflake

dbt-snowflake contains all of the code enabling dbt to work with Snowflake

https://getdbt.com

Apache License 2.0

297 stars 177 forks source link

Adap 321/support all on schema change options #1195

Closed VersusFacit closed 1 month ago

VersusFacit commented 1 month ago

related to fully supporting #321

Problem

alter statements in incremental strategies need the table format.

Solution

Thankfully, we were well set up to leverage our existing relation abstractions to make these work out of box.

scenarios hand-tested:

sync_all_columns:
- add column
- remove a column
- add and remove a column
append_new_columns:
- add columns
- don't delete columns that no longer are in DDL

✅ These changes only apply to incremental-run affected columns

Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have run this code in development and it appears to resolve the stated issue
[ ] This PR includes tests, or tests are not required/relevant for this PR
[x] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX