Add query tag back to incremental models - Githubissues

dbt-labs / dbt-snowflake

dbt-snowflake contains all of the code enabling dbt to work with Snowflake

https://getdbt.com

Apache License 2.0

296 stars 176 forks source link

Add query tag back to incremental models #1212

Closed mikealfare closed 1 month ago

mikealfare commented 1 month ago

Problem

We inadvertently removed query tags on incremental models when implementing Iceberg support.

Solution

Add query tags back to incremental models
Fix the query tag test that should have caught this, but didn't

I'm skipping the changelog on this since this is a pre-regression that we caught prior to final release.

Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

mikealfare commented 1 month ago

CI is failing due to the pending update for py38 retirement and the related change in branch protection rules. This should be resolved once the py38 retirement PR is merged, which contain the expected workflows.