Update unit test mocks to handle the new `query_id` field - Githubissues

dbt-labs / dbt-snowflake

dbt-snowflake contains all of the code enabling dbt to work with Snowflake

https://getdbt.com

Apache License 2.0

296 stars 176 forks source link

Update unit test mocks to handle the new `query_id` field #1238

Closed mikealfare closed 1 week ago

mikealfare commented 2 weeks ago

Problem

We added query_id as a new field on the AdapterResponse event. This needs to be a string to pass validation.

Solution

Mock the sfqid method to return a string literal instead of the mocked object it gets via MagicMock.

Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

mikealfare commented 2 weeks ago

Kick the CI