fix: update to use pyhive function to get compatible sasl

ntnhaatj commented 2 months ago

resolves #1094 docs dbt-labs/docs.getdbt.com/#

Problem

Current SASL factory for TSaslClientTransport using SASLClient from pure-sasl which is incompatible with pyhive

Solution

Pyhive provides a wrapper PureSASLClient which implement some missing methods to interact with thrift-sasl.

This MR update to use get_installed_sasl of pyhive to decide which sasl client should be use in current environment.

Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

cla-bot[bot] commented 2 months ago

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: nhat.nguyent. This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] commented 2 months ago

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @ntnhaatj

cla-bot[bot] commented 2 months ago

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @ntnhaatj

nqvuong1998 commented 2 months ago

Hi @McKnight-42 , any update for this PR?

dbt-labs / dbt-spark