Apply "Initial refactoring of incremental materialization"

hiloboy0119 commented 1 month ago

Problem

dbt-spark uses the old method of applying incremental materialization macros.

This PR is a draft because I also dropped support for python 3.8 to get tests to pass. I will remove that commit when pull/1121 is merged

Solution

Applies "Initial refactoring of incremental materialization" (https://github.com/dbt-labs/dbt-core/pull/5359).

Now it uses adapter.get_incremental_strategy_macro instead of dbt-spark's dbt_spark_get_incremental_sql macro to dispatch the incremental strategy macro.

Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

cla-bot[bot] commented 1 month ago

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Drew Goya. This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] commented 1 month ago

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Drew Goya. This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] commented 1 month ago

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @hiloboy0119

cla-bot[bot] commented 1 month ago

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @hiloboy0119

dbt-labs / dbt-spark