dbt-labs / dbt-spark

dbt-spark contains all of the code enabling dbt to work with Apache Spark and Databricks
https://getdbt.com
Apache License 2.0
405 stars 227 forks source link

Ct 276/iceberg support patch #651

Closed VersusFacit closed 1 year ago

VersusFacit commented 1 year ago

resolves #432

Description

Patches to dparent1's pr here.

I have addressed all comments that I could find open/unaddressed in their PR. I also rewrite the bulk of the list_relations_without_caching method.

image

Me running some runs against my dockerized iceberg instance.

Checklist

dparent1 commented 1 year ago

I've run my original testcase with this change and it is working for me! Thanks so much for this @VersusFacit, I'll close my other PR.

Fokko commented 1 year ago

Thanks @dparent1 for creating the PR and @VersusFacit & @mikealfare for picking this up! Great to see this happening!

dparent1 commented 1 year ago

Thanks @dparent1 for creating the PR and @VersusFacit & @mikealfare for picking this up! Great to see this happening!

This made my day when I turned my computer on this morning. Also @Fokko was very much instrumental in keeping this PR alive, thanks goes to you as well as the others.