Finish Constraint Support for Spark

dbt-labs / dbt-spark

dbt-spark contains all of the code enabling dbt to work with Apache Spark and Databricks

https://getdbt.com

Apache License 2.0

400 stars 227 forks source link

Closed peterallenwebb closed 1 year ago

peterallenwebb commented 1 year ago

resolves #656, resolves #657

Add model-level constraint support to Spark

[x] I have read the contributing guide and understand what's expected of me
[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
[x] I have run changie new to create a changelog entry

dbeatty10 commented 1 year ago

Heads-up @peterallenwebb: the pull request description needs to be something like this to close multiple issues:

resolves #656, resolves #655

Otherwise, it will only auto-close the first issue, and the subsequent issue(s) will be left open.

dbeatty10 commented 1 year ago

@peterallenwebb Nevermind my comment about syntax for resolves since it looks like #655 is already closed.

dbeatty10 commented 1 year ago

@peterallenwebb nevermind my nevermind 😅 -- from the changelog entry, it appears that you meant #657 instead of #655?

In that case, the PR description should be updated to:

resolves #656, resolves #657