dbt-labs / dbt-spark

dbt-spark contains all of the code enabling dbt to work with Apache Spark and Databricks
https://getdbt.com
Apache License 2.0
400 stars 227 forks source link

Add the all flag to the pip install #778

Closed JCZuurmond closed 10 months ago

JCZuurmond commented 1 year ago

Description

Make sure you install all dependencies when contributing.

Checklist

mikealfare commented 1 year ago

We've been running pip install -r requirements.txt (via tox/make) to do this, but I actually like this better as we don't have to maintain two versions, one in setup.py and one in requirements.txt. Would you mind making the updates to tox.ini and Makefile and removing requirements.txt to see if that all works together?

JCZuurmond commented 1 year ago

@mikealfare : I updated the accordingly. Could you have a look why the unit test CircleCI is failing due to a missing pyproject.toml. The Github action unit test is not failing

mikealfare commented 1 year ago

The tests on CircleCI are failing with this error:

#!/bin/bash -eo pipefail
tox -e flake8,unit
ERROR: missing /home/dbt_test_user/project/pyproject.toml

Exited with code exit status 1
CircleCI received exit code 1

We don't use pyproject.toml yet. I wonder if removing requirements.txt entirely caused some under the hood magic to look for pyproject.toml and then fail if it's not found. Just for fun, do you mind uploading an empty requirements.txt with a comment along the lines of "this makes CircleCI happy"?

github-actions[bot] commented 10 months ago

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

github-actions[bot] commented 10 months ago

Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers.