dbt-labs / dbt-spark

dbt-spark contains all of the code enabling dbt to work with Apache Spark and Databricks
https://getdbt.com
Apache License 2.0
400 stars 227 forks source link

Standardize the adapter for core debug changes #794

Closed VersusFacit closed 1 year ago

VersusFacit commented 1 year ago

PR to bring adapter in parity with this core PR.

I confirmed this debug_query does work. But, _connection_keys does not. I think we need to filter what params make it to the connection phase in core. That requires further scoping. After this is merged, I'll make a followup option.

Checklist

VersusFacit commented 1 year ago

Now includes test cases (fixes or skips) to get things passing on main tomorrow ahead of the release.

But I can't give you all the connection keys because: 07:11:20 ('07002', '[07002] [Simba][ODBC] (10690) Expected descriptor record does not exist during query execution. (10690) (SQLExecDirectW)'). This will take some investigation/filtering(?) in core.