Add ConnectionWrapper base class

dbt-labs / dbt-spark

dbt-spark contains all of the code enabling dbt to work with Apache Spark and Databricks

https://getdbt.com

Apache License 2.0

395 stars 221 forks source link

Add ConnectionWrapper base class #828

Closed Fokko closed 1 year ago

Fokko commented 1 year ago

resolves #829

Description

Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
[] I have run changie new to create a changelog entry

JCZuurmond commented 1 year ago

@Fleid: This PR is ready to be merged

JCZuurmond commented 1 year ago

@McKnight-42 : The CI's are failing unrelated to the code changes. We have seen that CI being flacky before. Could you investigate that?

McKnight-42 commented 1 year ago

@JCZuurmond no worries i can rekick off the failing tests and I'll keep and eye on it.

colin-rogers-dbt commented 1 year ago

Looks like spark-session tests are failing due to:

>   from dbt.spark.adapters import ConnectionWrapper
E   ModuleNotFoundError: No module named 'dbt.spark'

/root/project/dbt/adapters/spark/session.py:12: ModuleNotFoundError

Probably just a missing dependency in our spark image

Fokko commented 1 year ago

@mikealfare @colin-rogers-dbt I think my PR was in a limbo state, I didn't correctly push my local changes because it was stuck in a merge. After fixing that, mypy was vocal again, and I had to push a few more changes. @JCZuurmond PTAL