search

dbt-labs / dbt-spark

dbt-spark contains all of the code enabling dbt to work with Apache Spark and Databricks
https://getdbt.com
Apache License 2.0
395 stars 221 forks source link

[ADAP-790] [Bug] tblproperties macro not used when creating table neccessary for iceberg tables #865

Closed etheleon closed 1 year ago

etheleon commented 1 year ago

Is this a new bug in dbt-spark?

Current Behavior

tblproperties macro is declared but not used

Expected Behavior

include in adaptors.sql so it'll be rendered when creating table

Steps To Reproduce

  1. include tblproperties in model config
  2. dbt run
  3. table created without tblproperties

Relevant log output

No response

Environment

- OS: Ubuntu 20.04
- Python: 3.9
- dbt-core: 
- dbt-spark: 1.5.0

Additional Context

No response

etheleon commented 1 year ago

require automated test to test if this adds tblproperties to the create table statement

dbeatty10 commented 1 year ago

Resolved in https://github.com/dbt-labs/dbt-spark/pull/848