persist view column comments

[jurasan]

resolves #372

Problem

View column description is not persisted in view schema.

Solution

View column description is persisted as a column level comment. Used this dbt-snowflake commit as an example.

Checklist

• [x] I have read the contributing guide and understand what's expected of me
• [x] I have run this code in development and it appears to resolve the stated issue
• [ ] This PR includes tests, or tests are not required/relevant for this PR
• [x] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

I was not able to run tests on it. Here is the PR with the test, but in tests it cannot call dbt-core macros.

@internalcode
    def _fail_with_undefined_error(
        self, *args: t.Any, **kwargs: t.Any
    ) -> "te.NoReturn":
        """Raise an :exc:`UndefinedError` when operations are performed
        on the undefined value.
        """
>       raise self._undefined_exception(self._undefined_message)
E       jinja2.exceptions.UndefinedError: 'get_columns_in_query' is undefined

../../miniconda3/lib/python3.10/site-packages/jinja2/runtime.py:852: UndefinedError

[cla-bot[bot]]

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @jurasan

[jurasan]

@cla-bot check:

[cla-bot[bot]]

The cla-bot has been summoned, and re-checked this pull request!

[colin-rogers-dbt]

@jurasan can you add a changelog summarizing this change?

[mikealfare]

@jurasan The failing code check is for whitespace in dbt/include/spark/macros/adapters.sql. You can either fix it manually or run pre-commit run --all-files to have it fix it for you.

Also, I don't understand why the test in your linked PR wouldn't be able to run in this PR. We regularly call dbt-core macros. Could you talk more about that?

[Fleid]

@JCZuurmond for information only

[jurasan]

@mikealfare

@jurasan The failing code check is for whitespace in dbt/include/spark/macros/adapters.sql. You can either fix it manually or run pre-commit run --all-files to have it fix it for you.

fixed this

Also, I don't understand why the test in your linked PR wouldn't be able to run in this PR. We regularly call dbt-core macros. Could you talk more about that?

Yes, we do call dbt-core macros, but If you look at the test_macros.py I don't think those are tested. Maybe it's because of the way those macros are called in __run_macro method?

[colin-rogers-dbt]

Set this to auto-merge, looks like all tests are passing. @jurasan can you update your branch with the latest from main?

[colin-rogers-dbt]

resolved in #893