dbt-labs / dbt-spark

dbt-spark contains all of the code enabling dbt to work with Apache Spark and Databricks
https://getdbt.com
Apache License 2.0
395 stars 221 forks source link

Remove unused mypy ignore #882

Closed Fokko closed 1 year ago

Fokko commented 1 year ago

resolves #883 docs dbt-labs/docs.getdbt.com/#

check yaml...............................................................Passed
check json...........................................(no files to check)Skipped
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check for case conflicts.................................................Passed
black....................................................................Passed
flake8...................................................................Passed
mypy.....................................................................Failed
- hook id: mypy
- exit code: 1

dbt/adapters/spark/column.py:12: error: Unused "type: ignore" comment  [unused-ignore]
Found 1 error in 1 file (checked 8 source files)

Problem

Solution

Checklist

dataders commented 1 year ago

looks like this change was already done in #880

Fokko commented 1 year ago

Looks like it, thanks @dataders