dbt-labs / dbt-spark

dbt-spark contains all of the code enabling dbt to work with Apache Spark and Databricks
https://getdbt.com
Apache License 2.0
395 stars 221 forks source link

[ADAP-868] [Bug] Remove unused mypy ignore #883

Closed Fokko closed 1 year ago

Fokko commented 1 year ago

Is this a new bug in dbt-spark?

Current Behavior

Mypy is complaining

Expected Behavior

Happy mypy

Steps To Reproduce

Run pre-commit with mypy

Relevant log output

check yaml...............................................................Passed
check json...........................................(no files to check)Skipped
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check for case conflicts.................................................Passed
black....................................................................Passed
flake8...................................................................Passed
mypy.....................................................................Failed
- hook id: mypy
- exit code: 1

dbt/adapters/spark/column.py:12: error: Unused "type: ignore" comment  [unused-ignore]
Found 1 error in 1 file (checked 8 source files)

Environment

- OS:
- Python:
- dbt-core:
- dbt-spark:

Additional Context

No response

dataders commented 1 year ago

resolved by: #880