persist view column comments - Githubissues

dbt-labs / dbt-spark

dbt-spark contains all of the code enabling dbt to work with Apache Spark and Databricks

https://getdbt.com

Apache License 2.0

395 stars 221 forks source link

persist view column comments #893

Closed colin-rogers-dbt closed 1 year ago

colin-rogers-dbt commented 1 year ago

taking over #866 to get it over the finish line.

persist view column comments
format: whitespace
extracted get_matched_column macro
move parenthesis to the calling macro
changelog
fix: remove matching column in different case
fix: remove get_matched_column macro - not much logic left there.
escape column comments and add functional test

resolves #372 docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

[ ] I have read the contributing guide and understand what's expected of me
[ ] I have run this code in development and it appears to resolve the stated issue
[ ] This PR includes tests, or tests are not required/relevant for this PR
[ ] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

colin-rogers-dbt commented 1 year ago

@benc-db I think I've incorporated your feedback but please take a look