Switch ceil to floor - Githubissues

dbt-labs / dbt-spark

dbt-spark contains all of the code enabling dbt to work with Apache Spark and Databricks

https://getdbt.com

Apache License 2.0

395 stars 221 forks source link

Switch ceil to floor #894

Closed dapollak closed 5 months ago

dapollak commented 1 year ago

resolves # docs dbt-labs/docs.getdbt.com/#

Problem

When calculating datediff in "hour"s with spark, we get a result that is larger by 1 relatively to all other warehouses when using datediff.

Solution

Swapping CEIL and FLOOR as in all other cases

Checklist

[ ] I have read the contributing guide and understand what's expected of me
[ ] I have run this code in development and it appears to resolve the stated issue
[ ] This PR includes tests, or tests are not required/relevant for this PR
[ ] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

cla-bot[bot] commented 1 year ago

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @dapollak

github-actions[bot] commented 6 months ago

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

github-actions[bot] commented 5 months ago

Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers.