add tests for --empty flag - Githubissues

dbt-labs / dbt-spark

dbt-spark contains all of the code enabling dbt to work with Apache Spark and Databricks

https://getdbt.com

Apache License 2.0

395 stars 221 forks source link

add tests for --empty flag #948

Closed MichelleArk closed 10 months ago

MichelleArk commented 10 months ago

resolves https://github.com/dbt-labs/dbt-spark/issues/949 docs dbt-labs/docs.getdbt.com/# N/A

Problem

https://github.com/dbt-labs/dbt-core/pull/8971 introduced a new --empty flag that required implementation changes to the BaseRelation.

Solution

Add tests in dbt-bigquery to ensure expected behaviour of the new --empty flag when running with dbt-redshift.

Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

github-actions[bot] commented 10 months ago

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide.