dbt-labs / dbt-spark

dbt-spark contains all of the code enabling dbt to work with Apache Spark and Databricks
https://getdbt.com
Apache License 2.0
405 stars 227 forks source link

[ADAP-1074] [Implementation] Remove `invalid_insert_overwrite_delta_msg` message #962

Closed dbeatty10 closed 11 months ago

dbeatty10 commented 11 months ago

Is this your first time submitting a feature request?

Describe the feature

While researching https://github.com/dbt-labs/docs.getdbt.com/issues/4639, it looks like this code is unused since https://github.com/dbt-labs/dbt-spark/pull/700.

So I'd propose we remove it altogether.

Searching both dbt-spark and dbt-databricks didn't yield any other references to invalid_insert_overwrite_delta_msg:

Describe alternatives you've considered

One alternative is to leave it as-is.

It's not hurting anything functionality-wise, but it I was initially confused when reading through the code while researching the behavior of incremental strategies of dbt-spark and dbt-databricks.

Who will this benefit?

Removing unused pieces will make the code easier to read and maintain.

Are you interested in contributing this feature?

No response

Anything else?

No response