dbt-labs / docs.getdbt.com

The code behind docs.getdbt.com
https://docs.getdbt.com/
Apache License 2.0
113 stars 862 forks source link

accurate test summary #2107

Open maciejskorski opened 1 year ago

maciejskorski commented 1 year ago

Discussed in https://github.com/dbt-labs/docs.getdbt.com/discussions/2095

Originally posted by **maciejskorski** September 28, 2022 I find the test summary bit imprecise on reporting sub-selected tests. When I subselect ~ 70 tests to run, I see all of them counted in the summary. I would rather expect "found 4", or a two-line communicate "a) found 70, b) subselected 4". Would it be beneficial to give it some thinking and improving the message? ``` azureuser@mskorski:~/projects/test_project/dataops-dic-dbt$ dbt test --select tag:source_data 15:17:40 Running with dbt=1.0.4 15:17:40 Found 9 models, 78 tests, 0 snapshots, 0 analyses, 390 macros, 2 operations, 0 seed files, 9 sources, 0 exposures, 0 metrics 15:17:40 15:17:40 15:17:40 Running 1 on-run-start hook 15:17:40 1 of 1 START hook: dataops_dic.on-run-start.0................................... [RUN] 15:17:40 1 of 1 OK hook: dataops_dic.on-run-start.0...................................... [CREATE SCHEMA in 0.00s] 15:17:40 15:17:40 Concurrency: 6 threads (target='test') 15:17:40 15:17:40 1 of 4 START test test_clinical_rowcount........................................ [RUN] 15:17:40 3 of 4 START test test_labs_results_numeric..................................... [RUN] 15:17:40 2 of 4 START test test_labs_namemapping......................................... [RUN] 15:17:40 4 of 4 START test test_labs_rowcount............................................ [RUN] ```
runleonarun commented 1 year ago

@dbeatty10 should this be transferred over to Core?

runleonarun commented 1 year ago

@jtcohen6 What do you think?

mirnawong1 commented 7 months ago

hey @dbeatty10 or @jtcohen6 wanted to follow up on this> otherwise, happy to close this issue if it's not related to the docs.