add sl access control info

dbt-labs / docs.getdbt.com

The code behind docs.getdbt.com

https://docs.getdbt.com/

Apache License 2.0

118 stars 929 forks source link

add sl access control info #5608

Closed mirnawong1 closed 2 months ago

mirnawong1 commented 4 months ago

this pr adds new information on upcoming access control changes. new content added to teh existing set up SL doc.

docs project

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-getdbt-com	✅ Ready (Inspect)	Visit Preview	✅ 5 resolved	Jul 22, 2024 11:29pm

mirnawong1 commented 4 months ago

hey @rpourzand, this pr addresses the upcoming changes to access control. wanted to double check the following with you please:

is the 'env var' not supported' line still accurate?
I've tried gathering some screenshots but couldn't find them in my own sandbox, could you provide an screenshot of the credentials page?
is step 8 (generate service token) still applicable or duplicative? or does 'credentials' replace it?

rpourzand commented 3 months ago

hey @rpourzand, this pr addresses the upcoming changes to access control. wanted to double check the following with you please:

is the 'env var' not supported' line still accurate?

I've tried gathering some screenshots but couldn't find them in my own sandbox, could you provide an screenshot of the credentials page?

is step 8 (generate service token) still applicable or duplicative? or does 'credentials' replace it?

Correct - Env Var is the same! The new credential page is still under final development, but I can get screenshots for you once it's ready! We only have figma designs. Service Tokens are still required. In today's world, you have to authenticate with a service token, but that always only resolves to a single data platform credential. In the new world when we release this, you'll have the option for service tokens to resolve to multiple credentials.

mirnawong1 commented 3 months ago

This looks good so far! For the release note; can we add more things to our June release note for Semantic Layer, or is this a separate process?

hey @rpourzand, sounds good thanks for checking this out! so we can add more release items to this pr - however wanted to check if the timing would match the SL access control release? if timing for the release is flexible, happy to fold it in to the pr to save us the extra work! however if you want the release note to launch on a particular time to accommodate the changes, then i can open a separate pr to add them in!

rpourzand commented 2 months ago

Based on the discussions I had today:

Given that we're gating it, this changes the path a bit. In the future, the UI for everyone will look the same and the only change will be that Teams plans can't Add Credentials. They still do the mapping, unmapping, can add additional service tokens, etc, delete but those will all default to 1 credential. For now, it will be the exact same flow, so I think we keep it as is and have a section for enterprise. Sorry about the thrash.
i think we should also make a blurb about how (for both) credentials only dictate PHYSICAL access. Logical access to metrics/dimensions is a separate thing and on our roadmap.